Add Chrome store assets #5
Conversation
Summary of ChangesHello @twhetzel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces essential documentation and asset guidelines required for the successful publication of the "Gmail Row Highlighter" extension to the Chrome Web Store. It includes a transparent privacy policy, a comprehensive guide for the store listing, and detailed instructions for preparing promotional images and screenshots, ensuring the extension meets platform requirements and clearly communicates its features and privacy stance to users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds important documentation for publishing the extension to the Chrome Web Store, including a privacy policy and a store listing guide. The documents are well-structured and comprehensive. I've made a few suggestions to improve accuracy and clarity, particularly regarding permission descriptions and the requirement for a privacy policy, to ensure a smooth submission process. Please also remember to update the placeholder date in the privacy policy before publishing.
| @@ -0,0 +1,89 @@ | |||
| # Privacy Policy for Gmail Row Highlighter | |||
|
|
|||
| **Last Updated:** [Date] | |||
There was a problem hiding this comment.
The 'Last Updated' date is currently a placeholder. Please update this to reflect the date of the last modification before this privacy policy goes live. This is important for compliance and user trust.
|
|
||
| • Manifest Version 3 | ||
| • Uses Chrome's sync storage (rules sync across devices) | ||
| • Only requires storage permission |
There was a problem hiding this comment.
This line in the detailed description states that the extension 'Only requires storage permission'. This is inaccurate as the manifest.json also includes host_permissions for mail.google.com. To be transparent with users, it's important to mention all required permissions. I suggest updating this to include the host permission.
| • Only requires storage permission | |
| • Requires storage and host permissions for mail.google.com |
| https://twhetzel.github.io/highlight-gmail/PRIVACY_POLICY.md | ||
| ``` | ||
|
|
||
| **Note:** Chrome Web Store requires a privacy policy URL if your extension uses the storage permission and stores user data. Since this extension stores highlight rules, a privacy policy is recommended. |
There was a problem hiding this comment.
This note states that a privacy policy is 'recommended'. According to the Chrome Web Store Developer Program Policies, a privacy policy is required for any extension that handles 'personal or sensitive user data', which includes user-generated content like the highlight rules this extension stores. Using chrome.storage.sync further strengthens this requirement. To avoid potential rejection during the review process, I suggest changing 'recommended' to 'required'.
| **Note:** Chrome Web Store requires a privacy policy URL if your extension uses the storage permission and stores user data. Since this extension stores highlight rules, a privacy policy is recommended. | |
| **Note:** Chrome Web Store requires a privacy policy URL if your extension uses the storage permission and stores user data. Since this extension stores highlight rules, a privacy policy is required. |
| - Keep the detailed description updated when adding new features | ||
| - Screenshots should be clear and demonstrate the extension's value | ||
| - Promotional images are optional but can improve visibility | ||
| - Privacy policy is required if the extension collects any user data (this extension doesn't, but it's good practice to have one) |
There was a problem hiding this comment.
This note is slightly confusing. It states that the extension 'doesn't' collect any user data, but it does store user-created rules, which is considered user data by the Chrome Web Store. This contradicts the earlier, more accurate statement on line 156. To maintain consistency and clarity, I recommend rephrasing this to align with the fact that storing user rules necessitates a privacy policy.
| - Privacy policy is required if the extension collects any user data (this extension doesn't, but it's good practice to have one) | |
| - A privacy policy is required because the extension stores user-created rules in Chrome's storage. |
No description provided.