Add ext-intl requirement to composer.json #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intl-extra makes use of the `IntlDateFormatter` class, which is only available in the `intl` extension of PHP. However, this dependency is not noted in `composer.json`, which means installation succeeds, but usage fails with a rather mysterious error: ``` PHP Fatal error: Uncaught Error: Class "IntlDateFormatter" not found ``` To avoid this misunderstanding, add an explicit dependency on `intl` to composer.json, to make composer complain that the dependency is not met during installation.
Author
|
I just realised I probably should've sent this to twigphp/Twig#4702 instead. Done. Happy to make further changes if needed. |
Member
|
PRs must indeed be sent o the main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intl-extra makes use of the
IntlDateFormatterclass, which is only available in theintlextension of PHP. However, this dependency is not noted incomposer.json, which means installation succeeds, but usage fails with a rather mysterious error:To avoid this misunderstanding, add an explicit dependency on
intlto composer.json, to make composer complain that the dependency is not met during installation.