Last node as donor + variables#45
Open
krzysztof-ksiazek wants to merge 4 commits intotwindb:developfrom
Open
Conversation
…ries and wsrep_sst_donor_rejects_queries
Changes in GaleraNodeState to reflect real behavior
Member
|
Hi @krzysztof-ksiazek , Thank you for the PR. Actually, this is supposed to fix #31 , which we are working on this and probably next sprint. I'll reuse your code then. |
Author
|
Hi @akuzminsky, Yes, I saw that issue but I wasn't sure how long will it take you guys to complete it. This PR covers also two more cases which are pretty rare but still may cause some troubles if you happen to run into them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a case when last available node becomes a donor - it shouldn't go offline_soft all long as possible. I also added support for handling of wsrep_reject_queries (node doesn't accept any queries -> goes offline_soft) and wsrep_sst_donor_rejects_queries (node doesn't accept queries when in Donor/Desync state -> goes offline_soft).
Feel free to use it, base on it etc.