Skip to content

feat: Add tweet preview and tweeted URL to PR conversation #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IstoraMandiri wants to merge 2 commits into from
Closed

feat: Add tweet preview and tweeted URL to PR conversation #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13163d8
feat: Add tweet preview to PR conversation
IstoraMandiri Oct 5, 2022
60c7459
Fix preview summary when parsing threads
IstoraMandiri Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/pull-request/create-check-run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ async function createCheckRun(
process.exit(allTweetsValid ? 0 : 1);
}

const summary = parsedTweets
.map((tweet) => tweetToCheckRunSummary(tweet))
.join("\n\n---\n\n");

const response = await octokit.request(
"POST /repos/:owner/:repo/check-runs",
{
Expand All @@ -54,12 +58,20 @@ async function createCheckRun(
conclusion: allTweetsValid ? "success" : "failure",
output: {
title: `${parsedTweets.length} tweet(s)`,
summary: parsedTweets.map(tweetToCheckRunSummary).join("\n\n---\n\n"),
summary,
},
}
);

toolkit.info(`check run created: ${response.data.html_url}`);

// post preview to the PR conversation
await octokit.rest.issues.createComment({
owner: payload.repository.owner.login,
repo: payload.repository.name,
issue_number: payload.pull_request.number,
body: `## Added ${parsedTweets.length} tweet(s)\n\n${summary}`,
});
}

function tweetToCheckRunSummary(tweet) {
Expand Down