Fix Python 3 compatibility for newer Twisted#73
Merged
Conversation
…bService Drop Python 2 support: replace the version-conditional double putChild call with a single b'http-bind' bytes call, and remove the now-unused sys import. Add self.reactor to HttpbService so newer Twisted (22+) can access site.reactor in server.Session.__init__. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Travis CI is no longer functional for this repo. Replace it with a GitHub Actions workflow that tests on Python 3.10-3.13 against both the latest Twisted release and Twisted trunk, with and without PyOpenSSL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
punjab.tac: replace the version-conditional doubleputChildcall with a singleb'http-bind'bytes call and remove the unusedsysimportself.reactor = reactortoHttpbService.__init__so newer Twisted (22+) can accesssite.reactorinserver.Session.__init__Context
PR #72 fixed
putChildneeding bytes on Python 3 but used a version check that registered the child twice. Additionally,HttpbServicewas missing areactorattribute required by newer Twisted whenserver.Session.__init__callssite.reactor.Test plan
python3 -c "from punjab.httpb import HttpbService"imports without errortrial punjabto confirm existing tests pass🤖 Generated with Claude Code