-
Notifications
You must be signed in to change notification settings - Fork 47
feat(utxorpc): add block to WatchTx #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe change updates block_to_txs in Changes
Sequence Diagram(s)sequenceDiagram
participant Source as Chain Source
participant Watch as Watcher (block_to_txs)
participant Map as Mapper
participant GRPC as gRPC Server
participant Client as Client
Source->>Watch: Emit block body
rect rgb(235,255,235)
note over Watch: New behavior — embed block
Watch->>Map: map_block_cbor(body)
Map-->>Watch: block_cbor
Watch->>Watch: Build AnyChainBlock(native_bytes, chain=Cardano(block_cbor))
Watch->>GRPC: AnyChainTx{ tx, block: Some(AnyChainBlock) }
GRPC-->>Client: Stream AnyChainTx with block populated
end
rect rgb(245,245,245)
note over Watch: Prior behavior — no block
Watch->>GRPC: AnyChainTx{ tx, block: None }
GRPC-->>Client: Stream AnyChainTx without block
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by CodeRabbit