add support for shareImage #457
Conversation
drawBot/drawBotDrawingTools.py
Outdated
| """ | ||
| path = tempfile.mkstemp(suffix=f".{format}")[1] | ||
|
|
||
| self.saveImage(path, **kwargs) |
There was a problem hiding this comment.
Sounds like a job for saveImage("NSImage"). The tempfile just keeps hanging around.
Also: shouldn't this be a proper menu item rather than a library function?
There was a problem hiding this comment.
the cool thing to have this as library function is that it can be run from code outside the app.
|
finally all test are green! |
drawBot/drawBotDrawingTools.py
Outdated
| # share it over airdrop | ||
| shareImage('pdf', service="airdrop") | ||
| """ | ||
| path = tempfile.mkstemp(suffix=f".{format}")[1] |
There was a problem hiding this comment.
Like I commented earlier, can we do this without a temp file? It's not being cleaned up, and I don't see how it could be. It's also not necessary as far as I can see: the sharing API works with all kinds of object, such as NSImage. Perhaps in-memory PDF data can be shared, too.
There was a problem hiding this comment.
A pdfDocument has no paste board support which is a requirement to send objects over.
The NSSharingService class is used to provide a consistent user experience when sharing items—NSURL objects, NSString objects, NSImage objects, video (through file URLs), or any object that implements the NSPasteboardWriting protocol—in macOS.
--> https://developer.apple.com/documentation/appkit/nssharingservice?language=objc
gif or mp4 has also no paste board support
its indeed not cleaned up, as it needs to be available during the sharing process
I could add a NSSharingServiceDelegate where a callback is received when the sharing is done
https://developer.apple.com/documentation/appkit/nssharingservicedelegate?language=objc
There was a problem hiding this comment.
Then it indeed needs to be cleaned up with a delegate.
There was a problem hiding this comment.
this is silly: the delegate removes the assets to fast and fe mail can not find it anymore...
see https://gist.github.com/typemytype/ea02152e754a5b0225df2df23976afd5
drawBot/drawBotDrawingTools.py
Outdated
| """ | ||
| path = tempfile.mkstemp(suffix=f".{format}")[1] | ||
|
|
||
| context = getContextForFileExt("pdf") |
There was a problem hiding this comment.
Btw. why does this go via the pdf context and not via the regular saveImage()? Would this work for anything but pdf?
There was a problem hiding this comment.
cause it needs to be format this is wrong of me :)
There was a problem hiding this comment.
Question still stands: why not plain saveImage()?
There was a problem hiding this comment.
must be self.saveImage(..) indeed
this does not work when sharing over mail. The file is already removed before mail popup up
No description provided.