Skip to content

Resolved mismatch stubbings in MultiRequestHttpClientServiceImplTest.java #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ARMS2025 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolved mismatch stubbings in MultiRequestHttpClientServiceImplTest.java #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/test/java/org/jasig/portlet/proxy/service/web/MultiRequestHttpClientServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ public void setUp() {

when(request.getPreferences()).thenReturn(preferences);
when(request.getPortletSession()).thenReturn(session);
when(preferences.getValue(MultiRequestHttpClientServiceImpl.HTTP_CLIENT_CONNECTION_TIMEOUT,
String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT)))
.thenReturn(String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT));
when(preferences.getValue(MultiRequestHttpClientServiceImpl.HTTP_CLIENT_CONNECTION_REQUEST_TIMEOUT,
String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_REQUEST_TIMEOUT)))
.thenReturn(String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_REQUEST_TIMEOUT));
Expand All @@ -63,6 +60,10 @@ public void setUp() {

@Test
public void testGetSharedClient() {
when(preferences.getValue(MultiRequestHttpClientServiceImpl.HTTP_CLIENT_CONNECTION_TIMEOUT,
String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT)))
.thenReturn(String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT));
when(session.getAttribute("org.springframework.web.util.WebUtils.MUTEX", 1)).thenReturn(null);
when(preferences.getValue(MultiRequestHttpClientServiceImpl.SHARED_SESSION_KEY, null)).thenReturn("sharedSession");
when(session.getAttribute("sharedSession", PortletSession.APPLICATION_SCOPE)).thenReturn(client);

Expand All @@ -72,6 +73,8 @@ public void testGetSharedClient() {

@Test
public void testGetUnsharedClient() {
when(preferences.getValue("sharedSessionKey", null)).thenReturn(null);
when(session.getAttribute("org.springframework.web.util.WebUtils.MUTEX", 1)).thenReturn(null);
when(session.getAttribute(MultiRequestHttpClientServiceImpl.CLIENT_SESSION_KEY, PortletSession.PORTLET_SCOPE)).thenReturn(client);

HttpClient response = service.getHttpClient(request);
Expand All @@ -80,6 +83,9 @@ public void testGetUnsharedClient() {

@Test
public void testCreateSharedClient() {
when(preferences.getValue(MultiRequestHttpClientServiceImpl.HTTP_CLIENT_CONNECTION_TIMEOUT,
String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT)))
.thenReturn(String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT));
when(preferences.getValue(MultiRequestHttpClientServiceImpl.SHARED_SESSION_KEY, null)).thenReturn("sharedSession");
HttpClient response = service.getHttpClient(request);
assertNotNull(response);
Expand All @@ -88,6 +94,10 @@ public void testCreateSharedClient() {

@Test
public void testCreateUnsharedClient() {
when(preferences.getValue(MultiRequestHttpClientServiceImpl.HTTP_CLIENT_CONNECTION_TIMEOUT,
String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT)))
.thenReturn(String.valueOf(MultiRequestHttpClientServiceImpl.DEFAULT_HTTP_CLIENT_CONNECTION_TIMEOUT));
when(preferences.getValue("sharedSessionKey", null)).thenReturn(null);
HttpClient response = service.getHttpClient(request);
assertNotNull(response);
verify(session).setAttribute(MultiRequestHttpClientServiceImpl.CLIENT_SESSION_KEY, response, PortletSession.PORTLET_SCOPE);
Expand Down