Skip to content

Conversation

@uazo
Copy link
Owner

@uazo uazo commented Jan 15, 2026

Description

Patches for 144

All submissions

  • there are no other open Pull Requests for the same update/change
  • Cromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@PF4Public
Copy link

You'll need to import codecs:

FAILED: [code=1] gen/chrome/common/supervised_user_commands.mojom-module 
python3.13 ../../mojo/public/tools/mojom/mojom_parser.py --input-root ../.. --input-root gen --output-root gx
Traceback (most recent call last):
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Rele>
    Run(sys.argv[1:])
    ~~~^^^^^^^^^^^^^^
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Relen
    _ParseMojoms(mojom_files, input_roots, output_root, module_roots,
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                 args.enabled_features, module_metadata, allowed_imports)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Reles
    for mojom_abspath, ast in _Shard(_ParseAstHelper, map_args):
                              ~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Reled
    yield target_func(*arg_tuple)
          ~~~~~~~~~~~^^^^^^^^^^^^
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Reler
    src = _ResolveInclude(mojom_abspath, input_root_paths)
  File "/var/tmp/portage/www-client/ungoogled-chromium-144.0.7559.59_p1/work/chromium-144.0.7559.59/out/Relee
    with codecs.open(mojom_abspath, encoding='utf-8') as f:
         ^^^^^^
NameError: name 'codecs' is not defined. Did you forget to import 'codecs'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants