Skip to content

Conversation

@VivekPanyam
Copy link
Collaborator

@VivekPanyam VivekPanyam commented May 27, 2020

This PR passes user-specified RuntimeOptions to the OPE worker process when loading a model.

This enables us to easily add options without having to write special logic for OPE.

See #361 and #364 for examples.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #363 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   89.41%   89.44%   +0.03%     
==========================================
  Files          57       57              
  Lines        3900     3913      +13     
==========================================
+ Hits         3487     3500      +13     
  Misses        413      413              
Impacted Files Coverage Δ
source/neuropod/multiprocess/multiprocess.cc 78.75% <100.00%> (+0.91%) ⬆️
...ource/neuropod/multiprocess/multiprocess_worker.cc 95.45% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2afeab...44b8ab0. Read the comment docs.

@VivekPanyam VivekPanyam requested a review from selitvin May 27, 2020 08:03
@VivekPanyam VivekPanyam force-pushed the struct_serialization branch from 6e0a3c4 to 137a13e Compare May 28, 2020 04:57
Base automatically changed from struct_serialization to master May 28, 2020 15:20
@VivekPanyam VivekPanyam merged commit 11ba3c2 into master May 28, 2020
@VivekPanyam VivekPanyam deleted the ope_options branch May 28, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants