Settings for Cadence tools to add command line arguments #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisonliew
requested changes
May 10, 2023
Contributor
harrisonliew
left a comment
harrisonliew
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Approval is pending the small suggestion.
| lec_bin = self.get_setting("formal.conformal.conformal_lec_bin") | ||
| ccd_bin = self.get_setting("formal.conformal.conformal_ccd_bin") | ||
| lec_bin = self.get_setting("formal.conformal.conformal_lec_bin") + \ | ||
| self.get_setting("formal.conformal.conformal_lec_bin_args") |
Contributor
There was a problem hiding this comment.
This doesn't match the key in the defaults.yml below.
I think for the rest of them I'd prefer doing <tool>_extra_args for clarity instead of <tool>_bin_args or <tool>_args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs / Issues
#786
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?