Autopopulate grade ranged rubric by sumaiyamannan · Pull Request #192 · ucl-isd/moodle-mod_coursework

sumaiyamannan · 2025-12-23T01:31:43Z

Summary

Introduce automatic averaging of ranged rubric grades at the final marking stage, with the ability for the final assessor to review and adjust individual rubric criteria before submission.

Use Case

When multiple assessors independently mark a submission using a Ranged Rubric, the final assessor should not need to re-enter grades from scratch. Instead, the system should pre-populate the final stage with the averaged results from earlier markers.

Configuration Requirements

mod_coursework activity settings

Marking workflow

Number of times each submission should initially be marked: 2
Automatic agreement of grades: No

Grade

Grading method: Ranged Rubric
Grading method for final stage: Same throughout all stages

Workflow

First assessor Logs in
-- Selects rubric criteria and assigns grades for each criterion
Second assessor Logs in
-- Selects rubric criteria and assigns grades independently
Final assessor Logs in
-- Sees each rubric criterion auto-populated with the average of the first and second assessor’s grades
-- Can adjust individual rubric criteria where required
-- Submits the final mark

Expected Behaviour

Login as the final assessor and see that the average criteria and grade from the previous two selections has been selected for the final assessor to change and submit

Each rubric criterion in the final stage is pre-selected using the average value of the prior assessors' selections.

The final assessor retains full control to override any averaged value.

No automatic agreement is enforced; the averaged values act as a starting point only.

Benefits

Reduces repetitive data entry for final assessors
Improves consistency and transparency in multi-marker workflows
Enhances usability of ranged rubric grading in Coursework

- Final assessor sees initial assessors selected in the criterion and grade - Supports range rubric grading method.

Copilot

Pull request overview

This PR introduces automatic population of ranged rubric grades during the final marking stage by averaging grades from initial assessors, allowing the final assessor to review and adjust criteria before submission.

Adds database query to calculate average grades and levels from initial assessors' rubric selections
Implements JavaScript module to pre-populate the final stage grading form with averaged values
Conditionally applies auto-population only when using ranged rubrics with manual agreement strategy

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.

File	Description
classes/models/coursework.php	Adds method to retrieve averaged rubric grades and helper to detect ranged rubric usage
classes/controllers/feedback_controller.php	Integrates auto-population logic into final stage feedback workflow
amd/src/rubric_ranges.js	Implements client-side form population using averaged grade data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T15:41:15Z

classes/models/coursework.php

+            LEFT JOIN {grading_instances} gi ON cf.id = gi.itemid
+            LEFT JOIN {gradingform_rubric_ranges_f} rr ON gi.id = rr.instanceid
+            WHERE cf.submissionid = :submissionid AND cf.stageidentifier NOT LIKE 'final_agreed_1' AND cf.finalised = 1 AND gi.status = 1
+            GROUP BY rr.criterionid ORDER  BY rr.criterionid ";


Double space in ORDER BY clause. Remove the extra space between 'ORDER' and 'BY' for consistency with SQL formatting standards.

Suggested change

GROUP BY rr.criterionid ORDER BY rr.criterionid ";

GROUP BY rr.criterionid ORDER BY rr.criterionid ";

Copilot · 2026-01-06T15:41:15Z

amd/src/rubric_ranges.js

+/**
+ * Modify ranged rubric grading form.
+ *
+ * @author    Sumaiya Javed <sumaiya.javed@catalyst.net.nz


Missing closing angle bracket in email address. The author tag should end with '>' after the email address.

Suggested change

* @author Sumaiya Javed <sumaiya.javed@catalyst.net.nz

* @author Sumaiya Javed <sumaiya.javed@catalyst.net.nz>

Copilot · 2026-01-06T15:41:16Z

classes/models/coursework.php


    /**
-     * @return grading_manager
+     * @return bool|gradingform_controller|null


The @return annotation specifies 'bool|gradingform_controller|null' but the function actually returns either an array of database records or null. Update the annotation to '@return array|false' to match the actual return type from get_records_sql().

Suggested change

* @return bool|gradingform_controller|null

* @return array|false|null

Copilot · 2026-01-06T15:41:16Z

classes/controllers/feedback_controller.php


+        // Autopopulate average grade from initial assessors.
+        if ($coursework && $coursework->is_using_ranged_rubric() && $teacherfeedback->stageidentifier == 'final_agreed_1') {
+            if (str_contains($coursework->automaticagreementstrategy, 'none')) {


Using str_contains() with 'none' as a substring match is fragile and could match unintended values like 'nonesuch'. Consider using strict equality comparison (=== 'none') or checking against a defined constant if the strategy field contains exactly 'none'.

Suggested change

if (str_contains($coursework->automaticagreementstrategy, 'none')) {

if ($coursework->automaticagreementstrategy === 'none') {

leonstr

I think this looks broadly OK, the only serious issue is whether we need the if in get_advanced_grading_average_grade_range_rubric() and if we do surely some default return value is needed (false or null?).

We probably also need to consider if this new behaviour should be enabled by default. Hopefully my colleagues will be able to give some input into this decision.

leonstr · 2026-01-06T15:47:37Z

classes/models/coursework.php

+            FROM {coursework_feedbacks} cf
+            LEFT JOIN {grading_instances} gi ON cf.id = gi.itemid
+            LEFT JOIN {gradingform_rubric_ranges_f} rr ON gi.id = rr.instanceid
+            WHERE cf.submissionid = :submissionid AND cf.stageidentifier NOT LIKE 'final_agreed_1' AND cf.finalised = 1 AND gi.status = 1


This uses NOT LIKE but the compared value doesn't contain a wildcard. Presumably this should be:

WHERE cf.submissionid = :submissionid AND cf.stageidentifier <> 'final_agreed_1' AND cf.finalised = 1 AND gi.status = 1

leonstr · 2026-01-07T15:40:47Z

classes/controllers/feedback_controller.php

+        // Autopopulate average grade from initial assessors.
+        if ($coursework && $coursework->is_using_ranged_rubric() && $teacherfeedback->stageidentifier == 'final_agreed_1') {
+            if (str_contains($coursework->automaticagreementstrategy, 'none')) {
+                $gdata = [];


I don't think this is needed. Why bother initialising $gdata when it's assigned on the next line?

leonstr · 2026-01-07T15:45:18Z

classes/controllers/feedback_controller.php

+        if ($coursework && $coursework->is_using_ranged_rubric() && $teacherfeedback->stageidentifier == 'final_agreed_1') {
+            if (str_contains($coursework->automaticagreementstrategy, 'none')) {


Rather than:

if (...) { if (...) { ⋮ } }

why not have a single if condition:

if ($coursework && $coursework->is_using_ranged_rubric() && $teacherfeedback->stageidentifier == 'final_agreed_1' && $coursework->automaticagreementstrategy === 'none') { ) {

leonstr · 2026-01-07T15:50:19Z

classes/models/coursework.php

+     */
+    public function get_advanced_grading_average_grade_range_rubric($submissionid) {
+        global $DB;
+        if ($submissionid) {


Do we need to check $submissionid here ? Could this actually be a falsy value? (Maybe it could but from a quick skim of the code I couldn't see how).

leonstr · 2026-01-07T15:51:49Z

classes/models/coursework.php

+            GROUP BY rr.criterionid ORDER  BY rr.criterionid ";
+            return $DB->get_records_sql($sql, ['submissionid' => $submissionid]);
+        }
+    }


If if ($submissionid) {} is false then nothing is returned, won't that break the caller? Should we have return false here?

leonstr · 2026-01-07T17:10:16Z

classes/controllers/feedback_controller.php

        $urlparams['stageidentifier'] = $teacherfeedback->stageidentifier;
        $PAGE->set_url('/mod/coursework/actions/feedbacks/new.php', $urlparams);

+        // Autopopulate average grade from initial assessors.


Given this relates to non-core functionality I think this comment should explicitly mention the plugin in this comment, for example:

// If using ranged rubric (gradingform_rubric_ranges) auto-populate average grade from initial assessors.

leonstr · 2026-01-07T17:12:15Z

classes/models/coursework.php

    }

+    /**
+     * Check if ranged rubric is used in the current coursework.


Again, since this relates to non-core functionality I think this comment should explicitly mention the plugin. For example:

* Check if ranged rubric (gradingform_rubric_ranges) is used in the * current coursework.

leonstr · 2026-01-07T17:14:01Z

amd/src/rubric_ranges.js

+ * Modify ranged rubric grading form.
+ *
+ * @author    Sumaiya Javed <sumaiya.javed@catalyst.net.nz
+ * @copyright Catalyst IT


Autopopulate grade ranged rubric

25e142b

- Final assessor sees initial assessors selected in the criterion and grade - Supports range rubric grading method.

sumaiyamannan force-pushed the autopopulategrade branch from c7a5378 to 25e142b Compare December 23, 2025 02:29

stuartlamour requested review from andrewhancox, Copilot, leonstr and watson8 January 6, 2026 15:40

Copilot AI reviewed Jan 6, 2026

View reviewed changes

leonstr requested changes Jan 7, 2026

View reviewed changes

	GROUP BY rr.criterionid ORDER BY rr.criterionid ";
	GROUP BY rr.criterionid ORDER BY rr.criterionid ";

	* @author Sumaiya Javed <sumaiya.javed@catalyst.net.nz
	* @author Sumaiya Javed <sumaiya.javed@catalyst.net.nz>

	* @return bool\|gradingform_controller\|null
	* @return array\|false\|null

	if (str_contains($coursework->automaticagreementstrategy, 'none')) {
	if ($coursework->automaticagreementstrategy === 'none') {

		if ($coursework && $coursework->is_using_ranged_rubric() && $teacherfeedback->stageidentifier == 'final_agreed_1') {
		if (str_contains($coursework->automaticagreementstrategy, 'none')) {

Conversation

sumaiyamannan commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

leonstr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sumaiyamannan commented Dec 23, 2025 •

edited

Loading