(Do not merge) Draft OC-191 #321
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file should have been regenerated before the merge of CP-23. CP-91 is assisting with correcting this oversight. References: * [OC-68] (CP-23) Convert current property restrictions and domain assertions to SHACL class shapes * [OC-193] (CP-91) Unit test validation results should be normalized Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-193] (CP-91) Unit test validation results should be normalized Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-193] (CP-91) Unit test validation results should be normalized Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
The results of this patch were reached in two ways: 1. By manually applying the normalization process to the Git-tracked state of the `*_validation.ttl` files in this directory. 2. By running `make clean && make check` in this directory. That both processes reached the same result means, aside from the missed results commit covered three commits back, no other changes were introduced to the validation results since UCO 0.7.0. References: * [OC-193] (CP-91) Unit test validation results should be normalized Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This is no longer necessary with recent releases of rdflib. This change supports tests for OC-12 and OC-191. References: * [OC-12] UCO's idea of "Open vocabulary" does not agree with its implementation with owl:oneOf * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
…ries This patch is known to trigger three unit test failures. The added tests need design discussion. This patch might not be preserved in UCO's development history, but its approximate effect is expected to be added as a unit test as a solution is identified. References: * [OC-12] UCO's idea of "Open vocabulary" does not agree with its implementation with owl:oneOf Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This is posted for design discussion. This patch might not be preserved in UCO's development history, but its approximate effect is expected to be added as a unit test as a solution is identified. No effects were observed on the Make-managed validation files. References: * [OC-12] UCO's idea of "Open vocabulary" does not agree with its implementation with owl:oneOf * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch is to isolate effects as another test is set up. References: * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [OC-191] Define JSON-LD context components that support semi-open vocabulary string literals Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
force-pushed
the
Draft-OC-191
branch
from
3dfd401 to
85f7964
Compare
ajnelson-nist
commented
Dec 7, 2021
| "@id": "kb:relationship2", | ||
| "@type": "ObservableRelationship", | ||
| "isDirectional": true, | ||
| "kindOfRelationship": { |
Contributor
Author
There was a problem hiding this comment.
@b0bkaT , this is the part that needs to work with context dictionaries.
Contributor
Author
There was a problem hiding this comment.
We want line 42 to read:
"kindOfRelationship": "Contained_Within"and the ObservableObjectRelationshipVocab should carry over to the Turtle translation. make check will fail if it doesn't convert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.