Update antipatterns.md, fixing an unintentional error in the code #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an unintentional error in the code for the linked lists sections. The text explains that the code is supposed to add up the elements of a linked list, yet for all 3 versions of the code (including the "correct code" version), the sum is only assigned to the value in each individual node, not adding up all the values. I fixed the code by changing `sum = p->data;` to `sum += p->data;` for all 3 versions. (This wasn't even the error that the example was trying to showcase! I was very confused when I first read through it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an unintentional error in the code for the linked lists sections. The text explains that the code is supposed to add up the elements of a linked list, yet for all 3 versions of the code (including the "correct code" version), the sum is only assigned to the value in each individual node, not adding up all the values.
I fixed the code by changing
sum = p->data;to
sum += p->data;for all 3 versions.
(This wasn't even the error that the example was trying to showcase! I was very confused when I first read through it.)