Skip to content

Move recipe definitions in dependencies.yml#192

Open
stanhu wants to merge 1 commit intoueno:masterfrom
stanhu:sh-move-recipes-in-yaml
Open

Move recipe definitions in dependencies.yml#192
stanhu wants to merge 1 commit intoueno:masterfrom
stanhu:sh-move-recipes-in-yaml

Conversation

@stanhu
Copy link
Collaborator

@stanhu stanhu commented Aug 28, 2024

A similar approach is used in native gems such as re2 and nokogiri. It makes it easier to auto-update the dependencies if they are in a YAML file.

A similar approach is used in native gems such as re2 and nokogiri.
It makes it easier to auto-update the dependencies if they are
in a YAML file.
Copy link
Owner

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nit

recipe.activate
end

[libgpg_error_recipe, libassuan_recipe]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to return a hash so the order of elements doesn't matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants