Explicitly use -std=c99 when compiling libgpg-error#200
Closed
JamieMagee wants to merge 1 commit intoueno:masterfrom
Closed
Explicitly use -std=c99 when compiling libgpg-error#200JamieMagee wants to merge 1 commit intoueno:masterfrom
-std=c99 when compiling libgpg-error#200JamieMagee wants to merge 1 commit intoueno:masterfrom
Conversation
265b1a4 to
391f33c
Compare
ueno
reviewed
Jul 17, 2025
| '--enable-static', | ||
| '--disable-nls', | ||
| "CFLAGS=-fPIC #{ENV["CFLAGS"]}", | ||
| "CFLAGS=-fPIC -std=c99 #{ENV["CFLAGS"]}", |
Owner
There was a problem hiding this comment.
The bundled libgpg-error is a bit outdated (the latest is 1.55). Perhaps bumping it would make this unnecessary?
Contributor
Author
There was a problem hiding this comment.
Yes, I created #201 which also solves the issue. If you merge that, I'll close this.
Contributor
Author
|
Closing as this was resolved in #201 |
JamieMagee
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 26, 2025
JamieMagee
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 26, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC changed the default C standard from
gnu17tognu23in GCC 151This started causing errors when compiling
libgpg-errornullptris a reserved constant in C232, so the compilation fails.This change explicitly adds
-std=c99toCFLAGSwhen compilinglibgpg-errorto avoid this issue.This issue was also fixed upstream by renaming
nullptrtonull_ptr3 and released inlibgpg-error1.51.Closes #199
Footnotes
https://gcc.gnu.org/gcc-15/changes.html#c ↩
https://en.cppreference.com/w/c/language/nullptr.html ↩
https://github.com/gpg/libgpg-error/commit/d14c69a7f256a9444c5c64b808d8767e5a8ba68e ↩