Bump gpgme to 2.0.0 and libassuan to 3.0.2#203
Merged
ueno merged 2 commits intoueno:masterfrom Jul 24, 2025
Merged
Conversation
- Bumped `gpgme` from `1.21.0` to `2.0.0` - https://github.com/gpg/gpgme/blob/master/NEWS - Bumped `libassuan` from `2.5.6` to `3.0.2` - https://github.com/gpg/libassuan/blob/master/NEWS Changes I had to account for from `gpgme`: - Removed trust item functions - `gpgme_op_trustlist_start`, `gpgme_op_tristlist_next`, and `gpgme_op_trustlist_end` were removed - Removed `GPGME_ATTR_*` constants - Timestamp field type change - `gpgme_subkey_t`, `gpgme_key_sig_t`, and `gpgme_new_signature_t` changed from `signed long` to `unsigned long` - New functions - `gpgme_op_random_bytes` and `gpgme_op_random_value` - New constants - `GPGME_RANDOM_MODE_NORMAL`, `GPGME_RANDOM_MODE_ZBASE32`, `GPGME_DECRYPT_LISTONLY`, `GPGME_CREATE_GROUP` Closes ueno#202
JamieMagee
force-pushed
the
gpgme-2.0.0-libassuan-3.0.2
branch
from
9df2b53 to
b3c76c0
Compare
…ation Change verify() to decrypt() for encrypted+signed data in two failing tests: The tests were incorrectly calling verify() on data created with crypto.encrypt(text, :sign => true), which produces encrypted+signed data. The verify() method expects signed-only data, causing "Bad data" errors. The decrypt() method properly handles both decryption and signature verification for encrypted+signed data by calling ctx.decrypt_verify() internally, then processing the embedded signatures. This aligns with the existing pattern used in other working tests that handle signed encrypted data.
Contributor
Author
|
@ueno could I get your review on this please? |
ueno
approved these changes
Jul 24, 2025
Owner
ueno
left a comment
ueno
left a comment
There was a problem hiding this comment.
OK, I didn't realize that 2.0.0 had an ABI bump; thank you so much for the rework for that. LGTM!
Contributor
Author
|
@ueno you're welcome. Are you able to tag and publish a release please? |
Owner
Done. |
JamieMagee
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 26, 2025
JamieMagee
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 26, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpgmefrom1.21.0to2.0.0libassuanfrom2.5.6to3.0.2Changes I had to account for from
gpgme:gpgme_op_trustlist_start,gpgme_op_tristlist_next, andgpgme_op_trustlist_endwere removedGPGME_ATTR_*constantsgpgme_subkey_t,gpgme_key_sig_t, andgpgme_new_signature_tchanged fromsigned longtounsigned longgpgme_op_random_bytesandgpgme_op_random_valueGPGME_RANDOM_MODE_NORMAL,GPGME_RANDOM_MODE_ZBASE32,GPGME_DECRYPT_LISTONLY,GPGME_CREATE_GROUPCloses #202