Update deprecated key editing functions#207
Merged
ueno merged 6 commits intoueno:masterfrom Feb 5, 2026
Merged
Conversation
ueno
reviewed
Feb 5, 2026
Owner
ueno
left a comment
ueno
left a comment
There was a problem hiding this comment.
Looks great, I only have a couple of nitpicks.
| * The shim callback converts keyword strings to status codes. | ||
| */ | ||
|
|
||
| /* Mapping table from keyword strings to status codes */ |
Owner
There was a problem hiding this comment.
I might define a macro to help define the entries and avoid copy and paste error, e.g.,:
#define S(x) { #x, GPGME_STATUS_##x }
Contributor
Author
There was a problem hiding this comment.
Ok, added a macro helper.
ext/gpgme/gpgme_n.c
Outdated
| int i; | ||
| if (!keyword) | ||
| return GPGME_STATUS_EOF; | ||
| for (i = 0; keyword_to_status[i].keyword != NULL; i++) { |
Owner
There was a problem hiding this comment.
nit: please follow the GNU coding style https://www.gnu.org/prep/standards/standards.html#Formatting
ueno
reviewed
Feb 5, 2026
ext/gpgme/gpgme_n.c
Outdated
| static gpgme_status_code_t | ||
| keyword_to_status_code (const char *keyword) | ||
| { | ||
| int i; |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the deprecated GPGME key editing functions with modern equivalents while maintaining backward compatibility.
Basically, use the various
interactfunctions on GPGME 2.0+ under the hood where possible.Fixed a few test warnings regarding unused variables while I was here.