-
Notifications
You must be signed in to change notification settings - Fork 7
feat: OJS 3.4/3.5 upgrade, Arabic locale, PHP8 compat, docs (README/CHANGELOG/CITATION) #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saddamalsalfi
wants to merge
11
commits into
ulsdevteam:master
Choose a base branch
from
saddamalsalfi:upgrade/ojs-3.4-3.5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: OJS 3.4/3.5 upgrade, Arabic locale, PHP8 compat, docs (README/CHANGELOG/CITATION) #18
saddamalsalfi
wants to merge
11
commits into
ulsdevteam:master
from
saddamalsalfi:upgrade/ojs-3.4-3.5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (TL;DR)
Upgrade Plum Analytics plugin for OJS 3.4.x / 3.5, add Arabic locale, PHP 7/8+ compatibility tweaks, and documentation/attribution. No DB/schema changes. License unchanged (GPL-2.0-or-later).
What’s changed
Bump version.xml → 1.6.1.0 and 2025-08-24.
PHP compatibility: add return type hints (e.g. register(): bool, getTemplatePath(): string, etc.).
Keep lazy-load behaviour; no changes in plugin settings keys.
Locales: add locale/ar/locale.po (keys mirrored to en).
Docs: update README with attribution, add CHANGELOG.md and CITATION.cff.
No changes to license headers (still GPL-2.0-or-later).
Compatibility
Target: OJS 3.4.x (tested) and 3.5 (intended; please validate).
PHP: tested on PHP 8.1/8.2 (syntax/type hints only; no BC breaks expected).
How I tested
Built a proper OJS package (.tar.gz) with a top-level folder plumAnalytics/ only.
Installed via Website → Plugins → Upload a New Plugin.
Enabled the plugin, verified settings open & save, and widgets render on article pages without errors.
Cleared caches and checked error logs (no new warnings).
Packaging note
If useful for reviewers, I can attach the .tar.gz built with the correct folder structure (plumAnalytics/) or publish it in a GitHub Release.
Attribution
Unofficial fork of ulsdevteam/ojs-plum-plugin. Upgraded/maintained for OJS 3.4/3.5 by Saddam Al-Salfi.
Contact: saddamalsalfi@qau.edu.ye
— Queen Arwa University.
Checklist
version.xml updated (release/date/class).
License preserved (GPL-2.0-or-later) + original notices intact.
Tarball packs a single top-level folder plumAnalytics/.
Locales validated (ar keys = en keys).
Smoke-tests on OJS 3.4.x, PHP 8.1/8.2.
Further validation on OJS 3.5 by maintainers.
Thanks!