UW3 release candidate

.github/ISSUE_TEMPLATE/architectural-review.yml

@@ -0,0 +1,130 @@
+name: Architectural Review
+description: Submit a formal architectural review for approval
+title: "[REVIEW] "
+labels: ["architectural-review", "review:submitted"]
+assignees: []
+
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ## Architectural Review Submission
+
+        This template is for formal architectural reviews documented in `docs/reviews/`.
+        These reviews cover system design, implementation rationale, and architectural decisions.
+
+        **See**: `docs/developer/CODE-REVIEW-PROCESS.md` for the full review process.
+
+  - type: input
+    id: review-doc
+    attributes:
+      label: Review Document Path
+      description: Path to review document in docs/reviews/
+      placeholder: docs/reviews/2025-11/FUNCTION-EVALUATION-SYSTEM-REVIEW.md
+    validations:
+      required: true
+
+  - type: dropdown
+    id: priority
+    attributes:
+      label: Priority
+      description: Urgency level for this review
+      options:
+        - HIGH
+        - MEDIUM
+        - LOW
+    validations:
+      required: true
+
+  - type: dropdown
+    id: review-type
+    attributes:
+      label: Review Category
+      description: Primary focus area of this review
+      options:
+        - System Architecture
+        - Code Implementation
+        - Testing Infrastructure
+        - Documentation
+        - Performance Optimization
+    validations:
+      required: true
+
+  - type: textarea
+    id: summary
+    attributes:
+      label: Executive Summary
+      description: 2-3 sentence overview of what this review covers
+      placeholder: |
+        This review documents the merger of evaluate() and global_evaluate() code paths,
+        introducing automatic lambdification optimization that provides ~10,000x speedup
+        for pure SymPy expressions through cached compiled functions.
+    validations:
+      required: true
+
+  - type: textarea
+    id: scope
+    attributes:
+      label: Scope & Key Changes
+      description: What files, systems, or components are affected?
+      placeholder: |
+        **Files Modified**:
+        - src/underworld3/function/functions_unit_system.py
+        - src/underworld3/function/pure_sympy_evaluator.py
+
+        **Systems Affected**:
+        - Function evaluation system
+        - Expression unwrapping
+        - DMInterpolation caching
+
+  - type: textarea
+    id: metrics
+    attributes:
+      label: Key Metrics
+      description: Quantified impacts (performance, test coverage, LOC, etc.)
+      placeholder: |
+        - Performance: 22s → 0.003s (7,400x faster)
+        - Test coverage: 20 comprehensive tests, all passing
+        - New code: ~360 lines in pure_sympy_evaluator.py
+
+  - type: textarea
+    id: dependencies
+    attributes:
+      label: Dependencies & Blockers
+      description: Does this review depend on or block other reviews?
+      placeholder: |
+        **Depends on**: None
+        **Blocks**: #XXX (Related feature implementation)
+        **Related**: #YYY (Units system review)
+
+  - type: checkboxes
+    id: checklist
+    attributes:
+      label: Pre-Submission Checklist
+      description: Ensure review is ready for formal evaluation
+      options:
+        - label: All referenced tests are passing
+          required: true
+        - label: Review document follows template structure
+          required: true
+        - label: Sign-off table is included
+          required: true
+        - label: Known limitations are documented
+          required: true
+        - label: Testing instructions are provided
+          required: true
+        - label: Tracking index (REVIEW-TRACKING-INDEX.md) is updated
+          required: true
+
+  - type: textarea
+    id: additional-context
+    attributes:
+      label: Additional Context
+      description: Any other information reviewers should know
+      placeholder: |
+        - Background discussions: Link to GitHub Discussions
+        - Related PRs: #XXX, #YYY
+        - External references: Papers, benchmarks, etc.
+
+# Reviewed for: Review System Infrastructure & GitHub Integration (Review #10, 2025-11-17)
+# Part of formal architectural review process implementation

.github/PULL_REQUEST_TEMPLATE/architectural-review.md

@@ -0,0 +1,136 @@
+<!--
+This PR template is for architectural review submissions.
+For regular code changes, delete this template and use the default.
+-->
+
+## Architectural Review Submission
+
+**Review Type**: [Code Implementation / System Architecture / Testing / Documentation / Performance]
+**Priority**: [HIGH / MEDIUM / LOW]
+**Review Period**: [YYYY-MM]
+
+---
+
+### 📄 Review Document
+- **File**: `docs/reviews/YYYY-MM/[NAME]-REVIEW.md`
+- **Related Issue**: Closes #XXX
+- **Tracking Index**: `docs/reviews/YYYY-MM/REVIEW-TRACKING-INDEX.md`
+
+### 📋 Executive Summary
+<!-- 2-3 sentence overview of what this review documents -->
+
+
+
+### 🎯 Scope
+**Systems Affected**:
+- [ ] Core solvers (Stokes, Poisson, Advection-Diffusion)
+- [ ] Variable system (Mesh/Swarm variables, arrays)
+- [ ] Units & non-dimensionalization
+- [ ] Parallel operations (MPI, collective operations)
+- [ ] Testing infrastructure
+- [ ] Documentation & examples
+- [ ] Other: _________________
+
+**Files Changed**:
+- New files: [count]
+- Modified files: [count]
+- Total LOC: ~[count]
+
+### ✅ Testing Status
+- [ ] All tests passing: `pixi run underworld-test`
+- [ ] New tests added: [count] tests
+- [ ] Test coverage: [X]% (or N/A)
+- [ ] Regression tests validated
+- [ ] Performance benchmarks run (if applicable)
+
+**Test Results**:
+```bash
+# Command used
+pixi run -e default pytest tests/test_XXXX*.py -v
+
+# Results summary
+[X] passed, [Y] failed, [Z] skipped
+```
+
+### 📊 Key Metrics & Impact
+<!-- Quantify the changes: performance, coverage, complexity -->
+
+**Performance**:
+- Before: [metric]
+- After: [metric]
+- Improvement: [X]x faster / [Y]% reduction
+
+**Quality**:
+- Test coverage: [X]%
+- Code complexity: [increase/decrease/unchanged]
+- Documentation: [X pages / X examples]
+
+### 🔍 Review Checklist (for Reviewers)
+
+**Design & Architecture**:
+- [ ] Design rationale is clear and well-justified
+- [ ] Trade-offs are documented with alternatives considered
+- [ ] System architecture is comprehensible
+- [ ] Integration points are identified
+
+**Implementation**:
+- [ ] Implementation matches documented design
+- [ ] Code quality meets project standards
+- [ ] Breaking changes are identified and justified
+- [ ] Backward compatibility is addressed
+
+**Testing & Validation**:
+- [ ] Testing strategy is adequate
+- [ ] Test coverage is sufficient
+- [ ] Edge cases are covered
+- [ ] Performance impact is assessed
+
+**Documentation**:
+- [ ] Known limitations are clearly documented
+- [ ] Benefits are quantified
+- [ ] User-facing changes are documented
+- [ ] Migration guide provided (if needed)
+
+### ⚠️ Known Limitations
+<!-- List any current constraints or future work needed -->
+
+1.
+2.
+
+### 🔗 Dependencies & Related Work
+**Depends on**:
+- [ ] Review #XXX (must be approved first)
+
+**Blocks**:
+- [ ] Review #YYY (waiting on this review)
+
+**Related**:
+- Discussion: [Link to GitHub Discussion]
+- Prior art: [Links to related reviews]
+
+---
+
+## 🖊️ Sign-Off
+
+**This PR merge represents formal approval of the architectural review.**
+
+Reviewers: Please review the full document at `docs/reviews/YYYY-MM/[NAME]-REVIEW.md` and approve this PR only when satisfied with the design, implementation, and documentation.
+
+| Role | GitHub Handle | Sign-Off Date | Status |
+|------|---------------|---------------|--------|
+| **Author** | @username | YYYY-MM-DD | ✅ Submitted |
+| **Primary Reviewer** | @reviewer1 | | ⏳ Pending |
+| **Secondary Reviewer** | @reviewer2 | | ⏳ Pending |
+| **Project Lead** | @lead | | ⏳ Pending |
+
+---
+
+### 📝 Additional Context
+<!-- Optional: Any other information reviewers should know -->
+
+
+
+<!--
+REVIEW HISTORY:
+- Review #10 (2025-11-17): Template created as part of Review System Infrastructure review
+-->