Open
Conversation
katdom13
reviewed
Jun 9, 2023
| - name: Test with tox | ||
| id: test-with-tox | ||
| run: | | ||
| tox |
katdom13
reviewed
Jun 9, 2023
| py{38,39,310}-dj{32,40}-wt{216,30,40} | ||
| py{39,310}-dj{41}-wt{40,41} | ||
| py{38,39,310}-dj{32,41,42}-wt{41,42,50} | ||
| py{311}-dj{41,42}-wt{41,42,50} |
There was a problem hiding this comment.
If this can be condensed, this is good, but for some reason, it fails for me in another package:
https://github.com/katdom13/wagtailmenus/actions/runs/5217610335/jobs/9417615529
it seems like Wagtail 4.1 and 4.2 don't really support Django 4.2
Contributor
Author
There was a problem hiding this comment.
@katdom13 You are right, I made a change thanks.
|
Hi @nickmoreton , LGTM, |
katdom13
approved these changes
Jun 9, 2023
katdom13
approved these changes
Jun 13, 2023
|
you might wanna consider changing the requirement of wagtail.contrib.modeladmin since it's now deprecated. |
This was referenced Oct 3, 2023
Closed
|
Hi @nickmoreton , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the package for Wagtail 5.0 support.
Support ticket: https://torchbox.monday.com/boards/1124794299/pulses/1131920812
There's no reason the package wouldn't work on versions since 4.1
This adds some testing for the latest version of Django and Wagtail
This builds on PR: #19