feat: Add edit/add functionality in the TUI #8
+1,105
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the functionality to add and edit todos from within the TUI, where previously it was only possible to add todos via the CLI. The add/edit form is not perfect, visually it still needs some work and the list selector feels clumsy.
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive edit and add functionality to the TUI, allowing users to create and modify todos directly within the interactive interface. Previously, todos could only be added via the CLI.
Key changes include:
- Addition of form-based UI for adding and editing todos with title, description, and list selection
- Refactoring of storage layer into an interface with improved file handling (atomic writes, proper permissions)
- Introduction of a list definitions package for better abstraction
- Enhanced test coverage for the new functionality
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/version/version.go | Updated semantic version to development marker |
| internal/tui/tui_test.go | Added test helper, fixed spelling, and added comprehensive tests for form functionality |
| internal/tui/tui.go | Implemented form mode, field navigation, and rendering for add/edit functionality |
| internal/storage/storage.go | Refactored into interface definition for storage abstraction |
| internal/storage/file.go | New file-backed storage implementation with atomic writes and secure permissions |
| internal/storage/file_test.go | Tests for file storage atomicity and permissions |
| internal/model/todo.go | Added JSON tags and renamed Toggle method to ToggleCompleted |
| internal/list/list.go | New package defining list metadata and identifiers |
| internal/cmd/t.go | Updated command to use new storage interface and added title validation |
| internal/cmd/t_test.go | Tests for title validation logic |
| go.mod, go.sum | Updated dependencies and moved bubbles/bubbletea to direct dependencies |
| README.md | Enhanced documentation with installation instructions and clearer examples |
| .gitignore | Added Claude settings to ignore list |
| .github/workflows/*.yaml | Restructured CI/PR workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality to add and edit todos from within the TUI, where previously it was only possible to add todos via the CLI. The add/edit form is not perfect, visually it still needs some work and the list selector feels clumsy.