Skip to content

Hub login revert 939 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bod9001 wants to merge 26 commits into
base: develop
Choose a base branch
from

ServerConnectionNegotiationPort

00ca55c
Select commit
Loading
Failed to load commit list.
Open

Hub login revert 939 #246

ServerConnectionNegotiationPort
00ca55c
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Nov 6, 2025 in 0s

6 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 6
           

Complexity increasing per file
==============================
- UnitystationLauncher/ViewModels/ForgotPasswordViewModel.cs  6
- UnitystationLauncher/ViewModels/LauncherViewModel.cs  12
- UnitystationLauncher/Views/ForgotPasswordView.xaml.cs  2
- UnitystationLauncher/ViewModels/InstallationViewModel.cs  3
- UnitystationLauncher/ViewModels/ServerViewModel.cs  7
- UnitystationLauncher/ViewModels/SignUpViewModel.cs  11
- UnitystationLauncher/ViewModels/LoginStatusViewModel.cs  14
- UnitystationLauncher/ViewModels/LoginViewModel.cs  6
- UnitystationLauncher/ViewModels/MainWindowViewModel.cs  8
- UnitystationLauncher/Views/SignUpView.xaml.cs  2
- UnitystationLauncher/Views/LoginView.xaml.cs  2
- UnitystationLauncher/Views/LoginStatusView.xaml.cs  2
- UnitystationLauncher/Models/Api/Server.cs  3
- UnitystationLauncher/Services/AuthService.cs  17
- UnitystationLauncher/Services/InstallationService.cs  86
- UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs  17
- UnitystationLauncher/Services/ApiServer.cs  15
- UnitystationLauncher/Models/AuthenticationStuff.cs  5
- UnitystationLauncher/Services/OfficialCentralCommandAuthentication.cs  22
- UnitystationLauncher/Services/ServerAuthenticationService.cs  7
         

Complexity decreasing per file
==============================
+ UnitystationLauncher/Models/Installation.cs  -1
+ UnitystationLauncher/Constants/ApiUrls.cs  -1
         

Clones added
============
- UnitystationLauncher/ViewModels/SignUpViewModel.cs  1
- UnitystationLauncher/ViewModels/LoginViewModel.cs  1
- UnitystationLauncher/Services/ApiServer.cs  2

See the complete overview on Codacy

Annotations

Check warning on line 30 in UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs#L30 

Remove this assignment of '_serverPipe' or initialize it statically.

Check failure on line 34 in UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs#L34 

Add a way to break out of this method's recursion.

Check warning on line 34 in UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs#L34 

The Cyclomatic Complexity of this method is 12 which is greater than 10 authorized.

Check warning on line 34 in UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/GameCommunicationPipe/PipeHubBuildCommunication.cs#L34 

This method 'StartServerPipe' has 103 lines, which is greater than the 80 lines authorized. Split it into smaller methods.

Check notice on line 5 in UnitystationLauncher/Models/Api/CharacterTokenResponse.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/Models/Api/CharacterTokenResponse.cs#L5 

Rename property 'token' to match pascal case naming rules, consider using 'Token'.

Check notice on line 50 in UnitystationLauncher/Models/AuthenticationStuff.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

UnitystationLauncher/Models/AuthenticationStuff.cs#L50 

Rename class 'Registersha512token' to match pascal case naming rules, consider using 'Registersha512Token'.
View more details on Codacy Production