-
Notifications
You must be signed in to change notification settings - Fork 574
switch triton kernels hash to v3.5.1 for gpt oss notebooks #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mmathew23, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Triton kernel dependency across several GPT OSS notebooks and their corresponding Python scripts. The primary goal is to ensure that these resources are compatible with Triton version 3.5 by referencing a newer, appropriate commit hash for the Triton kernels repository. This update is crucial for maintaining the functionality and performance of the machine learning workflows defined in these files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Triton kernel's commit hash across a large number of notebooks and scripts. The change itself is a straightforward dependency update. However, the fact that this change needs to be applied to dozens of files indicates a code duplication and maintainability issue. All these files contain a hardcoded installation command. I've left a comment on update_all_notebooks.py, which seems to be the script used for these updates, suggesting a way to centralize the dependency string to make future updates easier. A better long-term solution would be to manage dependencies in a shared requirements file.
| "unsloth_zoo[base] @ git+https://github.com/unslothai/unsloth-zoo" \ | ||
| "unsloth[base] @ git+https://github.com/unslothai/unsloth" \ | ||
| git+https://github.com/triton-lang/triton.git@05b2c186c1b6c9a08375389d5efe9cb4c401c075#subdirectory=python/triton_kernels | ||
| git+https://github.com/triton-lang/triton.git@0add68262ab0a2e33b84524346cb27cbb2787356#subdirectory=python/triton_kernels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request highlights a maintainability issue: the Triton commit hash is hardcoded in many files. While this script helps automate the update, the hash is still hardcoded within this script's multiline string. To make future updates easier and less error-prone, consider defining the Triton dependency string as a constant at the top of this file and referencing it here.
For example:
# At the top of the file
TRITON_COMMIT_HASH = "0add68262ab0a2e33b84524346cb27cbb2787356"
TRITON_PIP_URL = f"git+https://github.com/triton-lang/triton.git@{TRITON_COMMIT_HASH}#subdirectory=python/triton_kernels"
# ... then in the pip_install_block string, you can use an f-string and reference it:
pip_install_block = f"""...\
{TRITON_PIP_URL}
..."""A more robust long-term solution would be to have all notebooks install dependencies from a central requirements.txt file.
update triton kernels in notebooks to match triton 3.5