feat(navbar): integrate Upbound unified navigation theme #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
miloszsobczak
force-pushed
the
GLO-428/override-docs-theme-with-our-enhanced-nav-component
branch
from
668c62a to
9757d4a
Compare
miloszsobczak
force-pushed
the
GLO-428/override-docs-theme-with-our-enhanced-nav-component
branch
from
9757d4a to
62544f9
Compare
- Add @upbound/elements package for consistent navbar components - Implement custom Navbar/Content with unified Upbound branding - Add session and feature flags providers for auth integration - Configure custom hooks (useFeatureFlags, useSessionHooks) - Update search bar styling to match unified theme - Add TypeScript configuration and type definitions
miloszsobczak
force-pushed
the
GLO-428/override-docs-theme-with-our-enhanced-nav-component
branch
from
62544f9 to
be8c638
Compare
jeanduplessis
requested changes
Jan 19, 2026
|
|
||
| a:hover { | ||
| color: var(--link-hover-color); | ||
| /* color: var(--link-hover-color); */ |
Contributor
There was a problem hiding this comment.
Is it intentional to change how links look on hover or was this needed for the nav? Wondering if a more targeted rule would be better here?
| padding: 0 1.5rem; | ||
| backdrop-filter: blur(8px); | ||
| .main-wrapper { | ||
| /* padding-top: 3.5rem; */ |
Contributor
There was a problem hiding this comment.
If we don't need it, maybe we just remove it?
| @@ -0,0 +1,34 @@ | |||
| /** | |||
| * Copyright (c) Facebook, Inc. and its affiliates. | |||
Contributor
There was a problem hiding this comment.
What's with all the Facebook copyright notices?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❗ Not fully ready to be merged. Ahead of
docsprod deployment, we need to publish npm packages publicly.Type of change
Checklist
make lintlocally (or will fix Vale suggestions in review)Additional notes