Draft
Conversation
Contributor
|
Since we are also "forcing" users to use our own CMakeLists for projects on the engine, I do not see a reason why adding those three lines to the CMake could be an issue. The custom shell.html could be nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix building with Emscripten after the engine's init refactoring and updating to the latest Dawn version.
Building for web was quite convoluted because Dawn mantains its own fork of Emscripten with latest WebGPU API changes, but It has improved quite a lot last year. Now it's just as easy as fetching Dawn's repo and, in our case, adding the target library
emdawnwebgpu_c. You can check these changes here: upf-gti/WebGPU-distribution@5709054This also means we can stop using the old Tint repository (deprecated in 2024) and just use the latest Tint inside Dawn, for improved performance and latest features.
Also updated ImGui to latest commit, allowing us to remove the patch we made for web support.
Currently, apps using wgpuEngine as a library, must add these lines to their CMake to properly create the app's html:
I'm not sure we can do anything about it from the engine side.
Created as a draft until we fix the following issues: