Add support for glob alike pattern matching #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satazor
force-pushed
the
feature/support-glob-alike
branch
5 times, most recently
from
1d4f404 to
4a1d98d
Compare
boliveira
reviewed
Dec 2, 2024
boliveira
reviewed
Dec 2, 2024
boliveira
reviewed
Dec 2, 2024
boliveira
reviewed
Dec 2, 2024
satazor
force-pushed
the
feature/support-glob-alike
branch
2 times, most recently
from
3cb9783 to
8777b24
Compare
boliveira
previously approved these changes
Dec 2, 2024
satazor
force-pushed
the
feature/support-glob-alike
branch
3 times, most recently
from
db89d46 to
6fc8e71
Compare
satazor
changed the base branch from
master
to
enhancement/improve-performance
satazor
force-pushed
the
enhancement/improve-performance
branch
from
f0fd7c9 to
973a8b6
Compare
Also revamped README.
satazor
force-pushed
the
feature/support-glob-alike
branch
from
6fc8e71 to
16d3191
Compare
boliveira
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds support for similar behavior for
*and**of glob patterns. This is a breaking change since previously*meant to match anything afterwards.Besides being more intuitive for developers, glob matching allows for a common use-case of whitelisting properties of a given key, regardless of their depth. For example
**.error.codewill whitelisterror.codeat any tree level. Previously, we would had to repeat both**.error.codeanderror.codeto have the same behavior, or to use*error.codewhich will also whitelist anything that isn't namederrorexactly.Also revamped README and tests.