Send :read_timeout when streaming events (resolves #584) #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschmidt5189
changed the title
- Pins rspec-its to 1.x - Removes unnecessary setup steps for Ubuntu 20.10+ from ./scripts/install_podman.sh
danschmidt5189
force-pushed
the
bugfix/584/event_timeouts
branch
from
e314a05 to
65402d1
Compare
…ec_its Buildfix: pin rspec-its; simplify podman install (resolves upserve#597)
- Corrects a bug in `Docker::Connection.compile_request_params` that incorrectly stripped out `read_timeout` when it was nil. - Sets `Docker::Event.stream` to skip timeouts by default. - Sets `Docker::Event.stream` to avoid automatically retrying timeout-related events by default. - Adds timeout-related event streaming tests. A particularly slow (60s+) test can be enabled by setting `RUN_SLOW_TESTS=1` in the testing environment.
danschmidt5189
force-pushed
the
bugfix/584/event_timeouts
branch
from
65402d1 to
d5436e3
Compare
danschmidt5189
force-pushed
the
bugfix/584/event_timeouts
branch
from
01a6381 to
87daf35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker::Connection.compile_request_paramsthat incorrectly stripped outread_timeoutwhen it was nil.Docker::Event.streamto skip timeouts by default.Docker::Event.streamto avoid automatically retrying timeout-related events by default.RUN_SLOW_TESTS=1in the testing environment.