Implement strict departures #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With strict departure provided to the Problem, departures must not go beyond the provided place time windows (the existing behavior only limits arrival time)
rtpg
commented
Nov 12, 2025
| route_ctx.route(), | ||
| activity_ctx.target, | ||
| activity_ctx.target.schedule.arrival, | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
the core logic (we can't use self.activity.schedule.departure directly because that departure might be dynamically updated through break's activity cost...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I haven't added tests for this one just yet, but have added tests that use this to a private repository that validate that this is working.
When enabled in the plan configuration, this makes sure that departures must happen within a place's times, not just arrivals. This is especially important when dealing with breaks, because the departure there can be affected by a mid-job break.