Skip to content

%flap tutorial#170

Merged
sigilante merged 3 commits intomainfrom
js-client
Oct 4, 2022
Merged

%flap tutorial#170
sigilante merged 3 commits intomainfrom
js-client

Conversation

@sigilante
Copy link
Contributor

@sigilante sigilante commented Sep 28, 2022

As seen at Assembly 2022.

I've made some modest changes including serving all components directly from the ship.

I've personally run through all steps of this on a clean slate but it's worth a careful re-read and re-work as well.

@sigilante
Copy link
Contributor Author

The major blocking issue is that I want some changes to schooner.hoon. I could push those directly here but it's better to fix them upstream.

Copy link
Contributor

@tinnus-napbus tinnus-napbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me apart from the minor things above

also btw you'll need to add a card to the duo index page, otherwise it won't be listed in the additional guides section there, only if you actually open additional guides

@sigilante
Copy link
Contributor Author

@matildepark merci beaucoup

@sigilante sigilante merged commit 9803d19 into main Oct 4, 2022
@sigilante sigilante deleted the js-client branch October 4, 2022 16:44
@sigilante
Copy link
Contributor Author

ah shoot, forgot about schooner, will hotfix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants