Conversation
Contributor
Author
|
The major blocking issue is that I want some changes to |
tinnus-napbus
requested changes
Oct 4, 2022
Contributor
tinnus-napbus
left a comment
There was a problem hiding this comment.
looks good to me apart from the minor things above
also btw you'll need to add a card to the duo index page, otherwise it won't be listed in the additional guides section there, only if you actually open additional guides
Contributor
Author
|
@matildepark merci beaucoup |
Contributor
Author
|
ah shoot, forgot about schooner, will hotfix... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen at Assembly 2022.
I've made some modest changes including serving all components directly from the ship.
I've personally run through all steps of this on a clean slate but it's worth a careful re-read and re-work as well.