build: bump lmdb from 0.9.29 to master #954
Merged
+4
−10,339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary reason to upgrade lmdb here is the fact that latest master LMDB uses the NtCreateSection api to implement sparse files on windows. With the current windows binary every epoch immediately writes a 63 GB data.mdb file to disk which is less than ideal. Unfortunately there's no tagged release out with this fix, but this repository changes very infrequently and the LMDB guys know what they are doing so I determine the risk of upgrading here to be quite low. We also get LMDB/lmdb@82c5609 as a bonus with a fix for macos fsync so we can get rid of our patched mdb.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary reason to upgrade lmdb here is the fact that latest master LMDB uses the NtCreateSection api to implement sparse files on windows. With the current windows binary every epoch immediately writes a 63 GB data.mdb file to disk which is less than ideal.
Unfortunately there's no tagged release out with this fix, but this repository changes very infrequently and the LMDB guys know what they are doing so I determine the risk of upgrading here to be quite low.
We also get
LMDB/lmdb@82c5609 as a bonus with a fix for macos fsync so we can get rid of our patched mdb.c.