fix(theme): improve text contrast in default dark mode #5323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase OKLCH lightness of foreground text variables to meet WCAG contrast guidelines. This fixes low visibility in cards, calendar, buttons, sidebar and other components. Resolves usememos#5315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves readability in the default dark theme by increasing
the OKLCH lightness of multiple foreground text variables.
The current dark theme has low contrast in cards, calendar, sidebar,
and buttons, making text difficult to read (reported in #5315).
Changes
Why?
These values were too dim for a dark background (
oklch ~0.20–0.23)and did not meet recommended WCAG contrast levels.
The new values provide:
Related Issue
Resolves #5315
