create auditlogs bucket #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedparagon
reviewed
Jan 23, 2026
| resource "aws_s3_bucket" "auditlogs" { | ||
| bucket = "${var.workspace}-auditlogs" | ||
| force_destroy = var.force_destroy | ||
| object_lock_enabled = var.auditlogs_lock_enabled |
Contributor
There was a problem hiding this comment.
Suggested change
| object_lock_enabled = var.auditlogs_lock_enabled | |
| object_lock_enabled = var.auditlogs_lock_enabled ? "Enabled" : null |
I think this has to be a string. See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object_lock_configuration#object_lock_enabled-1
Contributor
Author
There was a problem hiding this comment.
Isn't that for s3_object_lock_configuration object? For s3_bucket the documentation says that object_lock_enabled expects a boolean. Check here
tedparagon
reviewed
Jan 23, 2026
tedparagon
reviewed
Jan 23, 2026
tedparagon
reviewed
Jan 23, 2026
tedparagon
requested changes
Jan 23, 2026
Contributor
tedparagon
left a comment
tedparagon
left a comment
There was a problem hiding this comment.
A couple changes requested.
franklingarcia-paragon
approved these changes
Jan 23, 2026
Contributor
franklingarcia-paragon
left a comment
franklingarcia-paragon
left a comment
There was a problem hiding this comment.
LGTM, Adrian is the object storage service expert! 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Closed
Brief Summary
Implemented auditlogs immutable storage and batch size env plumbing
Detailed Summary
Added dedicated auditlogs buckets/containers across AWS/GCP/Azure with immutability/retention controls to meet compliance requirements, and wired
AUDIT_LOGS_EVENT_BATCH_SIZEinto paragon Helm envs so batch writes are configurable. This aligns storage behavior with the new audit logging requirements while keeping configuration explicit and consistent across clouds.Steps to Test