Skip to content

[WIP] Disabled signing and deployment to Maven Central for "develop" branch#296

Open
rsherwood-nist wants to merge 1 commit intodevelopfrom
build-testing
Open

[WIP] Disabled signing and deployment to Maven Central for "develop" branch#296
rsherwood-nist wants to merge 1 commit intodevelopfrom
build-testing

Conversation

@rsherwood-nist
Copy link

@rsherwood-nist rsherwood-nist commented Jul 4, 2025

Committer Notes

This branch is for us to fix the build errors we are experiencing. This initial PR is designed simply to disable mvn central deployment for the develop branch.

All Submissions:

Changes to Core Features:

N/A

@iMichaela
Copy link

@rsherwood-nist - This PR is marked as WIP, but reviewers are assigned. Please clarify - is the PR ready fro review ? Thank you for your contribution.

@selenaxiao-nist selenaxiao-nist changed the base branch from main to develop November 25, 2025 18:38
Copy link

@selenaxiao-nist selenaxiao-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and tests in a local develop branch are successful.

@iMichaela
Copy link

@rsherwood-nist & @selenaxiao-nist - Can we please discuss the intent of this PR.

The PR removes the branch-check that limited the "build, test and deploy SNAPSHOT code" job to the develop branch, allowing to happen on any branch. It is rue, main is included, but it is too risky since it can be done from any branch.

Let's have a meeting and discuss it. I don't think it does what we discussed.

@selenaxiao-nist
Copy link

@iMichaela
I also initially suspected that the "build, test and deploy SNAPSHOT code" job would run on any branch, but when I tested on a local develop branch, this job was skipped. Regardless, let's have a meeting to test further.

@selenaxiao-nist selenaxiao-nist dismissed their stale review November 26, 2025 14:51

Dismissing to test branch condition further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants