Extend CRD to support configuring container.spec.lifecycle.preStop.command in injected container
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e database slice object by adding the 2 new fields. Printing test
… how condition is evaluated for []string fix(expand CRDs): Updated go dependencies and fixed issue with init container's lifecycle hooks support
MatteoMori8
force-pushed
the
AIRSHIP-4287/expand_dcb
branch
from
979a0a2 to
01145b4
Compare
…itional issues. Let's split the problem into 2 smaller ones. Temporarily removed support for InitContainer lifecyle hooks
MatteoMori8
changed the title
container.spec and initcontainer.speccontainer.spec.lifecycle.preStop.command
MatteoMori8
changed the title
container.spec.lifecycle.preStop.command container.spec.lifecycle.preStop.command in injected container
andreeaalexandra
previously approved these changes
Feb 11, 2025
MatteoMori8
force-pushed
the
AIRSHIP-4287/expand_dcb
branch
from
385ca86 to
e9a5a92
Compare
mmcgarr
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
container.specof the injected container so that we can support more flexibilitylifecycle.preStop.exec.commadavailable in the injected containercontainer.spec, we should do the same for initContainer too