-
Notifications
You must be signed in to change notification settings - Fork 31
Simple Parity Test #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simple Parity Test #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a Dafny proof for a parity property: if either x or y is even, then their product x*y is even. The implementation includes a predicate to check evenness and a test method with a corresponding proof lemma.
- Adds
isEvenpredicate that recursively checks if a natural number is even - Implements
ParityTestmethod that asserts the parity property usingParityProoflemma - Creates
ParityProoflemma stub in the proofs directory
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parity.dfy | Defines the isEven predicate and ParityTest method, but is located in the root directory instead of testcases/ where it should be according to the repository's build system |
| proofs/parity.dfy | Defines the ParityProof lemma with the appropriate ensures clause for the parity property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
As suggested by Copilot, the |
Have you verified this? Dafny can often infer decreasing quantities provided they are singular, like |
I have a proof which works without the decreases clause. Also, this file (proofs/parity.dfy) is for people to write their own proof, so this seems like an implementation-specific issue |
|
On my machine (Dafny 4.11.0+fcb2042d6d043a2634f0854338c08feeaaaf4ae2, WSL), I don't get an error saying it failed to prove termination for any loops. I think this is a good, simple-to-understand test case that people can get started with, so I'm approving it. |
JohnEdwardJennings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
A simple test case to learn dafny by proving a familiar concept: if x is even or y is even, then x*y is even.