Skip to content

Conversation

@phobos665
Copy link
Contributor

@phobos665 phobos665 commented Jan 30, 2026

This PR updates the launcher command for Epic to properly preserve spaces by wrapping the .exe with quotes to avoid the breaking of the launch.


Summary by cubic

Quote the Epic game executable path in the winhandler.exe command to preserve spaces and prevent launch failures. Updated logging to show the quoted command for easier debugging.

Written for commit a1cc3b9. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Epic game launcher command handling to properly support file paths containing spaces.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

Modified the Epic launch command construction in XServerScreen.kt to wrap the command path in quotes, ensuring proper handling of paths containing spaces and updating the logged output to reflect the quoted format.

Changes

Cohort / File(s) Summary
Epic Launch Command Quoting
app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
Added quotes around the epicCommand path in both the logging statement and the winhandler invocation to properly handle file paths containing spaces.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path with spaces caused quite the fright,
So quotes were added, now it's just right!
Command invocation, pristine and clear,
No more ambiguity to ever fear. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: fixing execution of Epic Games executables that contain spaces in their paths.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@phobos665 phobos665 changed the title Fix spaces epic games Fix execution of Epic Games exes/paths with spaces Jan 30, 2026
@phobos665 phobos665 changed the title Fix execution of Epic Games exes/paths with spaces Fix execution of Epic Games exes with spaces Jan 30, 2026
@utkarshdalal utkarshdalal merged commit 12d9117 into utkarshdalal:master Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants