Skip to content

Conversation

@phobos665
Copy link
Contributor

@phobos665 phobos665 commented Jan 30, 2026


Summary by cubic

Filter out Unreal Engine–related apps across Epic lists and search by excluding namespace 'ue' at the DB level. Consolidate DLC filtering in the DAO and remove the redundant check in the view model.

  • Bug Fixes
    • Added "AND namespace != 'ue'" to getAll() and searchByTitle() so UE tools/samples no longer appear.
    • Removed duplicate DLC filtering in LibraryViewModel; DAO enforces is_dlc = false.

Written for commit 22ec638. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Epic storefront listings now include DLC items when viewing Epic games in the library.
    • General game lists and title searches now exclude entries from a specific internal namespace, reducing irrelevant results.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

Adjusted Epic game filtering: DAO queries now exclude rows with namespace 'ue'; ViewModel removed the filter that previously excluded Epic DLC items, so DLCs are now included in Epic game results.

Changes

Cohort / File(s) Summary
Epic Games DAO
app/src/main/java/app/gamenative/db/dao/EpicGameDao.kt
Added namespace != 'ue' condition to getAll() and searchByTitle() SQL queries to exclude UE-namespaced rows.
Library ViewModel
app/src/main/java/app/gamenative/ui/model/LibraryViewModel.kt
Removed a filter that excluded Epic DLC entries; Epic DLCs will now appear in the Epic games list.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through code both swift and quick,
Tucked out the 'ue' with a gentle kick,
DLCs now dance in Epic's view,
A tiny change — a clearer cue. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: filtering out Unreal Engine dev applications from the Epic games list by adding a namespace exclusion.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/db/dao/EpicGameDao.kt`:
- Around line 52-53: The DAO queries are inconsistent: add the same UE filter
used in getAll() to public-facing queries so UE apps are excluded everywhere;
update the SQL for searchByTitle(), getByInstallStatus(), and any other queries
intended to mirror the main library view to include "AND namespace != 'ue'" (or
the equivalent parameterized namespace filter) and keep the is_dlc conditions in
place; locate the methods searchByTitle(), getByInstallStatus(), and any other
relevant query methods in EpicGameDao and modify their `@Query` strings to include
the namespace filter consistently.

@utkarshdalal utkarshdalal merged commit af4cec0 into utkarshdalal:master Feb 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants