-
-
Notifications
You must be signed in to change notification settings - Fork 89
fix(): filter out Unreal Engine dev applications #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): filter out Unreal Engine dev applications #462
Conversation
…-related applications.
📝 WalkthroughWalkthroughAdjusted Epic game filtering: DAO queries now exclude rows with namespace 'ue'; ViewModel removed the filter that previously excluded Epic DLC items, so DLCs are now included in Epic game results. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/db/dao/EpicGameDao.kt`:
- Around line 52-53: The DAO queries are inconsistent: add the same UE filter
used in getAll() to public-facing queries so UE apps are excluded everywhere;
update the SQL for searchByTitle(), getByInstallStatus(), and any other queries
intended to mirror the main library view to include "AND namespace != 'ue'" (or
the equivalent parameterized namespace filter) and keep the is_dlc conditions in
place; locate the methods searchByTitle(), getByInstallStatus(), and any other
relevant query methods in EpicGameDao and modify their `@Query` strings to include
the namespace filter consistently.
… already check for this.
Summary by cubic
Filter out Unreal Engine–related apps across Epic lists and search by excluding namespace 'ue' at the DB level. Consolidate DLC filtering in the DAO and remove the redundant check in the view model.
Written for commit 22ec638. Summary will update on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.