Skip to content

Conversation

@utkarshdalal
Copy link
Owner

@utkarshdalal utkarshdalal commented Jan 31, 2026


Summary by cubic

Updates the graphics wrapper and driver stack, refreshes sensible defaults, and rebuilds the Container Config dialog into a stable, tabbed UI. Adds Turnip Gen8 support, new DXVK/Zink assets, better GPU detection, and safer driver fallbacks.

  • New Features

    • Added DXVK 1.11.1-sarek and Zink DLL assets; included Turnip_Gen8_V23 driver and updated Turnip entries.
    • New defaults: DXVK 2.4.1-gplasync, wrapper turnip26.0.0_R8, async cache on; Adreno 8 Elite profile; 8 GB VRAM option.
    • Split ContainerConfigDialog into tabs (General, Graphics, Wine, Emulation, Controller, Drives, Environment, Advanced, WinComponents) with a shared ContainerConfigState to prevent UI crashes.
    • GPU/Vulkan: JNI vendor ID query, GPU device/vendor lookup from gpu_cards.json, new GALLIUM_HUD env var.
    • Image FS version bumped to v26.
  • Bug Fixes

    • Fixed driver extraction and cleanup (removes stale wrapper files when switching); warn and fall back to System when a selected Adrenotools driver is missing.
    • Correctly import drivers/contents with spaces and restore “install from manifest” behavior; stop normalizing manifest IDs.
    • arm64ec-specific OpenGL components handling; auto-disable the PATCH_OPCONSTCOMP SPIR-V pass for DXVK 1.11.1-sarek; ensure Vulkan resources are cleaned up.

Written for commit 866e533. Summary will update on new commits.

Summary by CodeRabbit

  • Refactor
    • Broadened version-matching logic to accept trimmed input and additional identifier forms, improving flexibility and consistency when resolving versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

Updated versionExists in ManifestComponentHelper.kt: trims the input version and returns true if any available item equals the trimmed value (case-insensitive) or if the parsed identifier of an available item equals the trimmed value (case-sensitive). Empty input still returns false.

Changes

Cohort / File(s) Summary
Version Comparison Logic
app/src/main/java/app/gamenative/utils/ManifestComponentHelper.kt
Changed versionExists to trim input and return true when any available item equals the trimmed input (case-insensitive) or when StringUtils.parseIdentifier(item) equals the trimmed input (case-sensitive). Empty input handling unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I nibbled code beneath the moon,

Trimmed a string, made checks in tune,
Case-insight and parsed delight,
Versions match — the logic's right,
A hop, a fix, and off I zoom! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'New wrapper 2026' is vague and does not clearly describe the actual changes made to the codebase. The raw summary shows a specific change to the versionExists logic in ManifestComponentHelper.kt, but the title provides no indication of this functionality. Replace the title with a specific, descriptive summary such as 'Update versionExists logic to support trimmed and case-insensitive matching' or similar, that clearly reflects the primary code change in the changeset.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch new-wrapper-2026

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@utkarshdalal utkarshdalal merged commit 88cedce into master Jan 31, 2026
3 checks passed
@utkarshdalal utkarshdalal deleted the new-wrapper-2026 branch January 31, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants