Stty: implemented hex and octal parsing for rows and columns #9516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2025
|
I'd mentioned here do this in an utility file and re-use it in all the places we should parse such integers |
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
from
6df507e to
0e13402
Compare
Contributor
Author
|
Good idea, I added a helper in the parser folder to be able to reuse that logic |
|
GNU testsuite comparison: |
This was referenced Nov 29, 2025
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
from
0e13402 to
7179ded
Compare
|
GNU testsuite comparison: |
3v1n0
reviewed
Dec 3, 2025
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
2 times, most recently
from
2094e6a to
9da9baa
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
from
0a2c101 to
432d123
Compare
CodSpeed Performance ReportMerging #9516 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Contributor
Author
|
The benchmark change is unrelated, should be good for another round of reviews |
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
from
432d123 to
a42b3e4
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
hex_octal_parsing
branch
from
65f25c2 to
9f7d01a
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 out of the 5 stty GNU tests are now passing and was taking a look at why the stty-row-col test was now failing. The issue was that the row and column options are able to accept hex and oct values and the parser we were using did not support the parsing of those values. This change makes the stty-row-col tests now pass.
I have modified the parser helper function and added tests that compare the output of the uutils implementation to the gnu implementation.