-
Notifications
You must be signed in to change notification settings - Fork 13
Shift to a src layout.
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@astrogewgaw Actually, I'd rather merge the cosmetic/linting changes separately, so when the time comes to make significant changes the PR is easy to review. Otherwise, It'll be drowning in thousands of lines worth of diff. Secondly, I am not particularly keen to move to nanobind, because pybind11 ain't broke and doesn't need fixing. Shorter compilation times are nice, but they are, let's face it, quite short already. Binary size is a non-issue, and runtime overheads of calling C code are non-existent in riptide. pybind11 also comes with nice utilities to trigger the build in setup.py (The Pybind11Extension class), while the only time I tried nanobind I had to struggle with CMake. I am concerned that the setup machinery will just become more complex for no visible gain. I'm happy to merge the 3 changes you mentioned:
But for nanobind, you'll have to convince me 😄 |
|
@v-morello No worries, let us do it this way then: I will edit this PR, and make it just for shifting PS: To address the point about the setup machinery, |
|
Good plan with the PR split 👍
The problem with
I'm OK to look at the diff and decide there, but then no promises, and I'm still leaning towards no. Please don't spend too much time on it, because I don't want to waste it. |
|
@v-morello No worries, I think I will work on this quite slowly anyways. Let us take it up when I am done with that PR. As for this one, let me know if there any changes required, and we can go ahead accordingly. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
v-morello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
Just as the title says, this PR shifts
riptideto asrclayout. To put it a bit more verbosely, the PR makes the following changes:src-based layout.black.These changes involve absolutely no changes to
riptide's functionality, since the source code has been left untouched (expect for being formatted).