Skip to content

Conversation

@Bubu-Droid
Copy link
Contributor

Change the vector form of direction of points to degrees

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification. This comment indicates a fix is needed to repair this.

How do I fix this?

For most of you, this means that the PR title should say either

  • fix: [short description here] (if you are fixing an issue)
  • feat: [short description here] (if you are introducing a new feature)

depending on whether you are fixing an issue or doing something new, respectively. But some other types might be suitable too, see the list below:

  • build: build related
  • ci: work related to CI
  • chore: updating deps, etc.
  • docs: documentation changes
  • drop: deleting stuff or removing a feature
  • edit: minor changes that don't constitute a new feature
  • perf: performance improvements
  • polish: copy editing or cleanup that doesn't affect functionality
  • refactor: major rewriting or restructuring that doesn't fix bugs or affect functionality
  • revert: revert commits
  • style: code style changes
  • test: unit testing, etc.

Please adjust the proposed title and this check will resolve automatically!

Detailed error message

No release type found in pull request title "Change dir to degrees". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • fix
  • feat
  • build
  • ci
  • chore
  • docs
  • drop
  • edit
  • perf
  • polish
  • refactor
  • revert
  • style
  • test

@Bubu-Droid Bubu-Droid changed the title Change dir to degrees feat: [Change dir to degrees] May 22, 2025
@vEnhance vEnhance changed the title feat: [Change dir to degrees] feat: Change dir to degrees May 22, 2025
@vEnhance
Copy link
Owner

I made a few formatting changes and also changed the code so that the angle measures are nonnegative (so between 0 and 360 rather than -180 and 180). Can you take a quick look and see that this looks OK?

@Bubu-Droid
Copy link
Contributor Author

Bubu-Droid commented May 22, 2025

I compiled an asy diagram with the changes. It works as intended.

@vEnhance vEnhance merged commit 783dbb4 into vEnhance:main May 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants