fix: TreeGrid children not showing after quick expand/collapse (24.9) [0.5 days] #8488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
When a TreeGrid node was expanded and then collapsed before data arrived from a slow data provider, subsequent expansion attempts would show no children. This was caused by the grid's sub-cache retaining a size of 0 from the cancelled request. The fix removes the sub-cache when collapsing an item with pending requests, allowing fresh data to be fetched on re-expand. Fixes vaadin/flow#21731
mcollovati
force-pushed
the
issues/21731-tree_grid_quick_expand_collapse_fails_v24
branch
from
f38854d to
995fd27
Compare
|
yuriy-fix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TreeGrid node was expanded and then collapsed before data arrived from a slow data provider, subsequent expansion attempts would show no children. This was caused by the grid's sub-cache retaining a size of 0 from the cancelled request.
The fix removes the sub-cache when collapsing an item with pending requests, allowing fresh data to be fetched on re-expand.
Fixes vaadin/flow#21731