feat: add signal-based text binding to Notification #8502
+435
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platosha
changed the title
platosha
force-pushed
the
feat/signals-constructor-notification
branch
from
4031eb7 to
8535f7b
Compare
platosha
changed the title
platosha
force-pushed
the
feat/signals-constructor-notification
branch
from
5401a8c to
2207926
Compare
Connected to: vaadin/flow#23193 Adds new constructors that allow binding the notification text to signals, enabling reactive updates. Also introduces a `bindText()` method for dynamic text binding management and refactors internal text handling using SignalPropertySupport.
platosha
force-pushed
the
feat/signals-constructor-notification
branch
from
2207926 to
df9c766
Compare
tltv
approved these changes
Jan 22, 2026
| Assert.assertEquals(10000, notification.getDuration(), 0); | ||
| Assert.assertEquals("top-end", | ||
| notification.getPosition().getClientName()); | ||
| Assert.assertTrue(notification.isAssertive()); |
Member
There was a problem hiding this comment.
nit: consider adding Assert.assertFalse(notification.isAssertive()); somewhere just to make sure it's not accidentally true by default.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to: vaadin/flow#23193
Depends on #8507
Adds new constructors that allow binding the notification text to signals, enabling reactive updates. Also introduces a
bindText()method for dynamic text binding management and refactors internal text handling using SignalPropertySupport.