feat: add signal support for Details component summary text #8521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds signal binding support for the Details component's summary text property through new constructors and binding methods. Connected to vaadin/flow#23193 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
36 tasks
tltv
reviewed
Jan 26, 2026
| } | ||
|
|
||
| /** | ||
| * Binds a signal to update the summary text of the details component. |
Member
There was a problem hiding this comment.
For consistency public bind* methods should say same message all over. For this case HasText::bindText(Signal<String>) works as a good template. Example is not needed since there are similar examples in most Flow API.
DiegoCardoso
requested changes
Jan 26, 2026
| if (getElement().getPropertyRaw("opened") == null) { | ||
| setOpened(false); | ||
| getElement().setProperty("opened", false); | ||
| } |
Contributor
There was a problem hiding this comment.
Is this change needed for the feature to work?
Comment on lines
+106
to
+108
| if (summary == null) { | ||
| summary = ""; | ||
| } |
Contributor
There was a problem hiding this comment.
This is also done for the other constructor that receives the summary as a String. Does it make sense to move it to the updateSummaryText() method?
| if (summary == null || !(summary instanceof Span)) { | ||
| updateSummary(new Span(newText)); | ||
| } else { | ||
| summary.getElement().setText(newText); |
Contributor
There was a problem hiding this comment.
This is not covered by any tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds signal binding support for the Details component's summary text property through new constructors and binding methods.
Connected to vaadin/flow#23193
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com