Refactor overleaf keymap to support dynamic prefix changes#15
Merged
vale981 merged 1 commit intovale981:mainfrom Jun 21, 2025
Merged
Refactor overleaf keymap to support dynamic prefix changes#15vale981 merged 1 commit intovale981:mainfrom
vale981 merged 1 commit intovale981:mainfrom
Conversation
Owner
|
Thanks for this! I knew the prefix configuration was quite broken, but haven't bothered to fix it yet. Could you squash your commits into one add the "refactor: " prefix to the message. I could do it, too of you'd like. |
Contributor
Author
I think I've done this just now, but the PR looks a bit messed up. Let me know if I should resubmit it. |
Owner
|
Oddly, there's one commit too many |
* overleaf.el (overleaf-keymap-prefix): Move definition after helper functions and add custom setter to update keymaps dynamically. Change type from 'string to 'key. (overleaf--key): Remove macro as it's no longer needed with new keymap structure. (overleaf-command-map): New keymap variable with overleaf commands. (overleaf-mode-map): New keymap variable that maps the prefix key to the command map. (overleaf-mode): Simplify keymap definition by using the new overleaf-mode-map variable instead of generating keymap from list of key definitions. * README.org (Usage): Remove incomplete sentence fragment.
Contributor
Author
OK, gave it another whirl. Hopefully this does the trick. |
Owner
|
Merci beaucoup ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR streamlines how the prefix key is handled, following standard practices in built-in Emacs modes (follow.el, outline.el, ...). The only user-facing difference is that keys are rebound as soon as the prefix key is modified.