fix: Fix and simplify handling of complex edits#22
Merged
vale981 merged 1 commit intovale981:mainfrom Jun 24, 2025
Merged
Conversation
* overleaf.el (overleaf--after-change-function): Fix use of faulty assumption that text added in complex edits occurs at the beginning of the region reported to the before-change hooks. Simplify handling of complex edits. Fixes vale981#21.
vale981
approved these changes
Jun 24, 2025
| (overleaf--queue-edit | ||
| `(:p ,(- overleaf--before-change-begin 1) :d ,old)) | ||
| (overleaf--queue-edit | ||
| `(:p ,(- overleaf--before-change-begin 1) :i ,final)) |
Owner
There was a problem hiding this comment.
This wouldn't have worked before, but recently I refactored the change synchronization with overleaf so that multiple edits are batched. Good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assumption that text added in complex edits occurs at the beginning of
the region reported to the before-change hooks. Simplify handling of
complex edits.
Fixes #21.