Skip to content

Comments

Don't fail on comments before the first element#37

Merged
valentiay merged 1 commit intomasterfrom
fix-start-element
Apr 23, 2025
Merged

Don't fail on comments before the first element#37
valentiay merged 1 commit intomasterfrom
fix-start-element

Conversation

@valentiay
Copy link
Owner

@valentiay valentiay commented Apr 23, 2025 •
edited
Loading

This PR fixes a bug when XmlDecoder fails on documents with comments before the first element like this one:

<?xml version="1.1" encoding="utf-8"?>
<!-- comment -->
<foo>
  <bar>bar</bar>
</foo>

@valentiay valentiay added this to the 0.26.0 milestone Apr 23, 2025
@valentiay valentiay merged commit 773ba9f into master Apr 23, 2025
1 check passed
@valentiay valentiay deleted the fix-start-element branch November 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

1 participant

@valentiay