insert reading of rosbag from ROS1 while system ROS is ROS2 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @valgur , I created this PR to enable the usage of the rosbags python package to be independent of the system ROS version. Can you maybe have a look on it? Additionally if it can be merged, it would be good if you can generate a new version of the corresponding python package. Thank you for your support. |
Owner
|
Thank you @flopie2009! I will try to merge these changes into the next release. Possibly not in this exact form, but adding support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inserts the functionality to use the rosbags package which is independent from the system ROS version. Resulting you can read ROS1 rosbags even if your system version is ROS2.