Skip to content

Add support for pushing Valkey-Bundle images to GHCR and Amazon ECR#76

Merged
roshkhatri merged 52 commits intovalkey-io:mainlinefrom
hanxizh9910:feature/add-public-ecr-ghcr-support
Dec 11, 2025
Merged

Add support for pushing Valkey-Bundle images to GHCR and Amazon ECR#76
roshkhatri merged 52 commits intovalkey-io:mainlinefrom
hanxizh9910:feature/add-public-ecr-ghcr-support

Conversation

@hanxizh9910
Copy link
Contributor

@hanxizh9910 hanxizh9910 commented Dec 9, 2025

Addresses #16

Summary

This PR adds support for publishing Valkey Bundle images to Github Container Registry and Amazon ECR Public Gallery

Required Secrets

For ECR publishing to work, the following repository secrets need to be configured:

  • AWS_ROLE_TO_ASSUME
  • ECR_REPOSITORY_ALIAS
  • ECR_REPOSITORY_NAME

Testing

Verified functionality by publishing to personal registries:

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
…n ghcr

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
…matically

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
…tomatially on ecr

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good PR, needs a few changes.

Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Signed-off-by: Hanxi Zhang <hanxizh@amazon.com>
Copy link
Member

@roshkhatri roshkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Asking @Nikhil-Manglore to take a look once

@Nikhil-Manglore
Copy link
Member

Code LGTM. In the link pasted above in the description it seems that we're parsing ## in the markdown file. I think it's fine for now because we'll be making that page dynamic anyways so we can update how we parse the template in that PR.

Example:
## What is [Valkey Bundle](https://github.com/valkey-io/valkey-bundle)?

@roshkhatri
Copy link
Member

Code LGTM. In the link pasted above in the description it seems that we're parsing ## in the markdown file. I think it's fine for now because we'll be making that page dynamic anyways so we can update how we parse the template in that PR.

Example: ## What is [Valkey Bundle](https://github.com/valkey-io/valkey-bundle)?

Yes we can open an issue for this and track it there.

@roshkhatri roshkhatri merged commit be3cb6c into valkey-io:mainline Dec 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants